Skip bitmap presence bits when pack and unpack message #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alovak
changed the title
|
this PR does not fix the same issue for composites. I'll fix it as well. |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #255 +/- ##
==========================================
+ Coverage 73.43% 73.48% +0.05%
==========================================
Files 43 43
Lines 2270 2282 +12
==========================================
+ Hits 1667 1677 +10
- Misses 373 374 +1
- Partials 230 231 +1
☔ View full report in Codecov by Sentry. |
adamdecaf
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #254
This PR adds the
IsBitmapPresenceBitmethod to theBitmap, allowing us to ignore fields that have the same index as bits, which indicate the presence of the next bitmap. By using this method, we can skip these fields when packing and unpacking a message.